| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up historical portability baggage |
| Date: | 2022-08-05 21:08:23 |
| Message-ID: | 20220805210823.u546w4p4wzfany7p@awork3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-08-06 09:02:32 +1200, Thomas Munro wrote:
> On Sat, Aug 6, 2022 at 12:01 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > On Thu, Aug 4, 2022 at 2:30 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> [strtoll cleanup patch]
> >
> > LGTM. This is just C99 <stdlib.h> stuff, and my scraped config data
> > set agrees with your observation.
>
> I found a couple of explicit references to these macros left in
> src/interfaces/ecpg/ecpglib/data.c and src/timezone/private.h.
> Removed in the attached, which I'll push a bit later if no objections.
Hah, I was about to push it. Thanks for catching these. Happy for you to push
this soon!
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imseih (AWS), Sami | 2022-08-05 21:28:16 | Re: [BUG] Panic due to incorrect missingContrecPtr after promotion |
| Previous Message | Thomas Munro | 2022-08-05 21:02:32 | Re: Cleaning up historical portability baggage |