| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should fix a comment referring to stats collector? |
| Date: | 2022-07-29 17:53:51 |
| Message-ID: | 20220729175351.j72wbqosv46c7anr@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jul-29, torikoshia wrote:
> Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there was
> a comment referring 'statistics collector' in pg_statistic.h.
>
> > Note that since the arrays are variable-size, K may be chosen by the
> > statistics collector.
>
> Should it be modified to 'cumulative statistics system' like manual on
> monitoring stats[1]?
I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.
Maybe it should just say "K may be chosen at ANALYZE time".
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Nadie está tan esclavizado como el que se cree libre no siéndolo" (Goethe)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-29 17:55:10 | Re: Oversight in slab.c SlabContextCreate(), initial memory allocation size is not populated to context->mem_allocated |
| Previous Message | Tom Lane | 2022-07-29 17:49:12 | Re: pg15b2: large objects lost on upgrade |