Re: pgsql: Default to hidden visibility for extension libraries where possi

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: 2022-07-19 13:18:01
Message-ID: 20220719131801.xltj7tupafzkj5dx@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2022-Jul-19, Pavel Stehule wrote:

> po 18. 7. 2022 v 3:06 odesílatel Andres Freund <andres(at)anarazel(dot)de> napsal:
>
> > Default to hidden visibility for extension libraries where possible

> Unfortunately, this commit definitely breaks plpgsql_check. Can the
> following routines be visible?

Do you just need to send a patch to add an exports.txt file to
src/pl/plpgsql/src/ for these functions?

plpgsql_build_datatype
plpgsql_compile
plpgsql_parser_setup
plpgsql_stmt_typename
plpgsql_exec_get_datum_type
plpgsql_recognize_err_condition
plpgsql_ns_lookup

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-19 13:45:52 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Alvaro Herrera 2022-07-19 08:16:32 pgsql: Wrap overly long lines

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-19 13:36:48 Re: Windows now has fdatasync()
Previous Message Japin Li 2022-07-19 13:08:53 Re: Memory leak fix in psql