Re: Weird mangling of a commit log entry in gitweb summary

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: Weird mangling of a commit log entry in gitweb summary
Date: 2022-07-18 08:19:14
Message-ID: 20220718081914.iyfx42a4e3jhvqox@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

Hi,

On Mon, Jul 18, 2022 at 09:34:23AM +0200, Alvaro Herrera wrote:
> On 2022-Jul-17, Magnus Hagander wrote:
>
> > On Sun, Jul 17, 2022 at 1:26 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > > 6 hours ago Tom Lane Remove postc's reset_shared() wrapper function. commit | commitdiff | tree
> > >
> > > What's up with that?
> >
> > I have no idea why but it's clearly getting confused by the single
> > quote. But it doesn't appear to do that in other places where there's
> > a single quote in there. I see nothing strange with the commit message
> > itself, and the cgit view of it shows nothing strange either...
>
> How do you know it's the single quote? The problem is not adjacent to
> that. Maybe it's replacing the string "branch name followed by period"
> with an empty string.

It looks like some gitweb's heuristics to try to reduce the title name:

https://github.com/git/git/blob/master/gitweb/gitweb.perl#L3570-L3572

> if (length($title) > 50) {
> $title =~ s/(master|www|rsync)\.//;
> }

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2022-07-18 08:27:47 Re: Weird mangling of a commit log entry in gitweb summary
Previous Message Alvaro Herrera 2022-07-18 07:34:23 Re: Weird mangling of a commit log entry in gitweb summary