| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix for make unportability |
| Date: | 2022-07-13 07:45:04 |
| Message-ID: | 20220713074504.wknclwsjlvbz4edl@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2022-Jul-13, Peter Eisentraut wrote:
> Fix for make unportability
>
> 88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell)
> construct that apparently confuses older GNU make versions (possibly
> because of the # inside the shell command?). This construct, which
> would allow # comments inside LINGUAS files, was adapted from gettext
> recommendations, but we don't actually need that functionality, so
> sidestep this whole issue by just using plain "cat".
I suppose if we're getting rid of Make soon, it's not really very useful
to make this more make-ish:
AVAIL_LANGUAGES := $(file <$(srcdir)/po/LINGUAS)
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-13 08:49:19 | pgsql: Fix XID list support some more |
| Previous Message | Peter Eisentraut | 2022-07-13 07:18:27 | pgsql: Fix for make unportability |