| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | melanieplageman(at)gmail(dot)com, pryzby(at)telsasoft(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, magnus(at)hagander(dot)net, pgsql-hackers(at)postgresql(dot)org, lukas(at)fittl(dot)com, thomas(dot)munro(at)gmail(dot)com |
| Subject: | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Date: | 2022-07-13 02:18:22 |
| Message-ID: | 20220713021822.x64uhtedsbhdxpmk@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-07-13 11:00:07 +0900, Kyotaro Horiguchi wrote:
> I imagined to use B_INVALID as a kind of "default" partition, which
> accepts all unknown backend types.
There shouldn't be any unknown backend types. Something has gone wrong if we
get far without a backend type set.
> We can just ignore that values but then we lose the clue for malfunction of
> stats machinery. I thought that that backend-type as the sentinel for
> malfunctions. Thus we can emit logs instead.
>
> I feel that the stats machinery shouldn't stop the server as possible,
> or I think it is overreaction to abort for invalid values that can be
> easily coped with.
I strongly disagree. That just ends up with hard to find bugs.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-07-13 02:41:40 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Previous Message | Kyotaro Horiguchi | 2022-07-13 02:00:07 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |