Re: pgsql: Only allow returning string types or bytea from json_serialize

At Thu, 07 Jul 2022 21:46:12 +0000, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote in
> Only allow returning string types or bytea from json_serialize

I noticed that this introcues the following error message.

+ errmsg("cannot use RETURNING type %s in JSON_SERIALIZE"
+ format_type_be(returning->typid)),

However, the same file has the following error message.

> errmsg("cannot use RETURNING type %s in %s",
> format_type_be(returning->typid), fname),

So, couldn't we share the format string to reduce translatable
messages?

And, the other messages are

cannot use RETURNING type %s in JSON_SCALAR(), and
cannot use RETURNING type %s in JSON()

So, I think this should not be

cannot use RETURNING type %s in JSON_SERIALIZE

, but should be

cannot use RETURNING type %s in JSON_SERIALIZE()

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center