Re: Support logical replication of DDLs

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: Zheng Li <zhengli10(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support logical replication of DDLs
Date: 2022-06-23 12:43:56
Message-ID: 20220623124356.gkndavscdkyg4pqq@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On 2022-Jun-15, houzj(dot)fnst(at)fujitsu(dot)com wrote:

> On Wednesday, June 15, 2022 8:14 AM Zheng Li <zhengli10(at)gmail(dot)com> wrote:

> > How does the deparser deparses CREATE FUNCTION STATEMENT? Will it
> > schema qualify
> > objects inside the function definition?
>
> The current deparser doesn't schema qualify objects inside the function
> source as we won't know the schema of inner objects until the function is
> executed. The deparser will only schema qualify the objects around
> function declaration Like:
>
> CREATE FUNCTION [public].test_func(i [pg_catalog].int4 ) RETURNS [pg_catalog].int4 LANGUAGE plpgsql

Right, this is by design. There is no way to deparse a function body --
as far as the backend is concerned, the body is just an opaque string.
That string is to be interpreted by the language handler only.

I don't know if it's possible to do different for non-core PLs, but I do
not think we have to worry about them in the Postgres implementation.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La victoria es para quien se atreve a estar solo"

In response to

Browse pgsql-general by date

  From Date Subject
Next Message WR 2022-06-23 15:13:50 Differences in Escaped bytea's when creating a plain pg_dump
Previous Message Amit Kapila 2022-06-23 10:00:27 Re: Support logical replication of DDLs

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema 2022-06-23 12:57:59 Re: WIP Patch: Add a function that returns binary JSONB as a bytea
Previous Message Simon Riggs 2022-06-23 12:34:54 Re: doc: Clarify Savepoint Behavior