| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | ParseTzFile doesn't FreeFile on error |
| Date: | 2022-05-30 08:37:40 |
| Message-ID: | 20220530.173740.748502979257582392.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While working on some patch, I saw the following error message when a
transaction ended successfully after a failed call to
parse_and_validate_value().
The cause is ParseTzFile() returns leaving an open file descriptor
unfreed in some error cases.
This happens only in a special case when the errors are ignored, but
in principle the file descriptor should be released before exiting the
function.
I'm not sure it's worth fixing but the attached fixes that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-ParseTzFile-to-call-FreeFile-on-error.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2022-05-30 08:44:18 | Re: Prevent writes on large objects in read-only transactions |
| Previous Message | Kyotaro Horiguchi | 2022-05-30 08:27:19 | Re: fix stats_fetch_consistency value in postgresql.conf.sample |