From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Steve Chavez <steve(at)supabase(dot)io>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Assert name/short_desc to prevent SHOW ALL segfault |
Date: | 2022-05-28 12:50:18 |
Message-ID: | 20220528125018.GA1876050@nathanxps13 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, May 28, 2022 at 12:26:34PM +0900, Michael Paquier wrote:
> On Fri, May 27, 2022 at 10:43:17AM -0700, Nathan Bossart wrote:
>> Makes sense. Here's a new patch set. 0001 is the part intended for
>> back-patching, and 0002 is the rest (i.e., adding pg_attribute_nonnull()).
>> I switched to using __has_attribute to discover whether nonnull was
>
> Okay, I have looked at 0001 this morning and applied it down to 12.
> The change in GetConfigOptionByNum() is not required in 10 and 11, as
> the strings of pg_show\all_settings() have begun to be translated in
> 12~.
Thanks!
>> supported, as that seemed cleaner. I didn't see any need for a new
>> configure check, but maybe I am missing something.
>
> And I've learnt today that we enforce a definition of __has_attribute
> at the top of c.h, and that we already rely on that. So I agree that
> what you are doing in 0002 should be enough. Should we wait until 16~
> opens for business though? I don't see a strong argument to push
> forward with that now that we are in beta mode on HEAD.
Yeah, I see no reason that this should go into v15. I created a new
commitfest entry so that this isn't forgotten:
https://commitfest.postgresql.org/38/3655/
And I've reposted 0002 here so that we get some cfbot coverage in the
meantime.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Introduce-pg_attribute_nonnull-and-use-it-for-Def.patch | text/x-diff | 3.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Roffild | 2022-05-28 12:59:40 | Re: postgres and initdb not working inside docker |
Previous Message | Tomas Vondra | 2022-05-28 12:35:00 | Re: Improving connection scalability (src/backend/storage/ipc/procarray.c) |