Re: bogus: logical replication rows/cols combinations

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: houzj(dot)fnst(at)fujitsu(dot)com, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: bogus: logical replication rows/cols combinations
Date: 2022-05-27 05:53:31
Message-ID: 20220527055331.GF19626@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote:
> On Tue, May 24, 2022 at 11:03 AM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > On Friday, May 20, 2022 11:06 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > Thanks for pointing it out. Here is the new version patch which add this version check.
>
> I have added/edited a few comments and ran pgindent. The attached
> looks good to me. I'll push this early next week unless there are more
> comments/suggestions.

A minor doc review.
Note that I also sent some doc comments at 20220519120724(dot)GO19626(at)telsasoft(dot)com(dot)

+ lists among publications in which case <command>ALTER PUBLICATION</command>
+ command will be successful but later the WalSender in publisher or the

COMMA in which

remove "command" ?

s/in publisher/on the publisher/

+ Subscription having several publications in which the same table has been
+ published with different column lists is not supported.

Either "Subscriptions having .. are not supported"; or,
"A subscription having .. is not supported".

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2022-05-27 06:22:38 Re: doc phrase: "inheritance child"
Previous Message Amit Kapila 2022-05-27 05:47:00 Re: bogus: logical replication rows/cols combinations