| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add --{no-,}bypassrls flags to createuser |
| Date: | 2022-05-23 16:37:35 |
| Message-ID: | 20220523163735.GA938919@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 23, 2022 at 11:55:43PM +0900, Shinya Kato wrote:
> On 2022-05-23 16:29, Michael Paquier wrote:
>> May I ask for the addition of tests when one specifies multiple
>> switches for --admin and --member? This would check the code path
>> where you build a list of role names. You could check fancier string
>> patterns, while on it, to look after the use of fmtId(), say with
>> role names that include whitespaces or such.
>
> Thanks!
> I changed to the test that describes multiple "-m".
> It seems to be working without any problems, how about it?
Michael also requested a test for multiple -a switches and for fancier
string patterns. Once that is taken care of, I think this can be marked as
ready-for-committer.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-05-23 16:41:42 | Re: docs: mention "pg_read_all_stats" in "track_activities" description |
| Previous Message | Zheng Li | 2022-05-23 15:40:17 | Re: Support logical replication of DDLs |