| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: create_help.pl treats <literal> as replaceable |
| Date: | 2022-05-18 00:58:05 |
| Message-ID: | 20220518.095805.2164390691449974704.horikyota.ntt@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Tue, 17 May 2022 11:09:23 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> but that just seems flat-out wrong. If "match" is a keyword it should
> be rendered like other keywords. I'm not very interested in splitting
> hairs about whether the grammar thinks it is a keyword --- it looks like
> one to a user. So I think
>
> HEADER [ <replaceable class="parameter">boolean</replaceable> | MATCH ]
>
> would be a better solution.
Oh, agreed. Thanks for the correction. By the way the error message in
defGetCopyHeaderChoice is as follows.
"%s requires a Boolean value or \"match\""
Should it be "%s requires a boolean value or MATCH"?
At least I think "Boolean" should be un-capitalized. The second
attached replaces "Booean" with "boolean" and the \"match\" above to
MATCH.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-copy-from-doc.patch | text/x-patch | 1.3 KB |
| 0002-Fix-wording-convention-in-error-messages.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2022-05-18 01:06:47 | Re: pgbench --partitions=0 |
| Previous Message | Michael Paquier | 2022-05-18 00:55:07 | Re: amcheck is using a wrong macro to check compressed-ness |