should check interrupts in BuildRelationExtStatistics ?

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: should check interrupts in BuildRelationExtStatistics ?
Date: 2022-05-09 00:01:08
Message-ID: 20220509000108.GQ28830@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Restarting a large instance took twice as long as I expected due to not
checking interrupts in (at least) statext_ndistinct_build. Long enough that I
attached (and was able to attach) a debugger to verify, which I think is too
long. I think it could cause issues for an high-availability cluster or other
script if it takes too long to shut down.

The tables being auto-analyzed have 9 exteneded stats objects, each with stats
target=10. 7 of those are (ndistinct) stats on 4 simple columns plus 1
expression (5 total). And the other 2 stats objects are expressional stats
(necessarily on a single expression).

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-05-09 00:24:06 Re: Possible corruption by CreateRestartPoint at promotion
Previous Message Thomas Munro 2022-05-08 23:30:06 Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To: