Re: pgsql: Backpatch addition of wait_for_log(), pump_until().

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Backpatch addition of wait_for_log(), pump_until().
Date: 2022-05-06 15:59:22
Message-ID: 20220506155922.5hqellfua6gx7vc6@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2022-05-06 15:29:43 +0200, Peter Eisentraut wrote:
> On 03.05.22 03:11, Andres Freund wrote:
> > Backpatch addition of wait_for_log(), pump_until().
> >
> > These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are
> > needed by a about-to-be-backpatched test.
>
> I see this warning:
>
> Subroutine pump_until redefined at t/013_crash_restart.pl line 246.

Yea :(. See bottom of https://postgr.es/m/20220506030927.6qehktk6bodv4ft3%40alap3.anarazel.de

> Also, the local definition has different arguments than the backpatched one.
> This should be double-checked.

That's as it's in the "original" commit...

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-05-06 16:36:15 pgsql: Temporarily skip recovery deadlock test in back branches.
Previous Message Andres Freund 2022-05-06 15:49:21 pgsql: Backpatch addition of pump_until() more completely.