From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com |
Cc: | daniel(at)yesql(dot)se, robertmhaas(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add --{no-,}bypassrls flags to createuser |
Date: | 2022-04-15 06:33:41 |
Message-ID: | 20220415.153341.594036939490942414.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Fri, 15 Apr 2022 14:55:48 +0900, Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> wrote in
> I understand. For backward compatibility, I left the ROLE clause
> option as it is and changed the IN ROLE clause option to --membership
> option.
Thanks!
- printf(_(" -g, --role=ROLE new role will be a member of this role\n"));
+ printf(_(" -g, --role=ROLE new role will be a member of this role\n"));
This looks lik an unexpected change. We shoudl preserve it, but *I*
think that we can add a synonym of the old --role for
understandability/memorability. (By the way "-g" looks like coming
from "group", which looks somewhat strange..)
> printf(_(" -b, --belongs-to=ROLE new role will be a member of this role\n"));
+ printf(_(" -m, --membership=ROLE this role will be a member of new role\n"));
membership sounds somewhat obscure, it seems *to me* members is clearer
> printf(_(" -m, --member=ROLE new role will be a member of this role\n"));
I'd like to hear others' opinions.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2022-04-15 07:26:01 | Re: Skipping logical replication transactions on subscriber side |
Previous Message | Kyotaro Horiguchi | 2022-04-15 06:19:22 | Re: Printing backtrace of postgres processes |