Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: robertmhaas(at)gmail(dot)com
Cc: markus(dot)wanner(at)enterprisedb(dot)com, michael(at)paquier(dot)xyz, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
Date: 2022-04-15 01:20:46
Message-ID: 20220415.102046.996618664940284064.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

At Thu, 14 Apr 2022 11:13:01 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in
> On Tue, Apr 12, 2022 at 6:55 AM Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > (My mailer has been fixed.)
>
> Cool.
>
> > So, I created the patches for back-patching from 10 to 14. (With
> > fixed a silly bug of the v1-pg14 that HaveVirtualXIDsDelayingChkpt and
> > HaveVirtualXIDsDelayingChkptEnd are inverted..)
>
> I am very sorry not to use these, but as I said in my previous post on
> this thread, I prefer to commit what I wrote and Markus revised rather
> than these versions. I have done that now.

Not at all. It's just an unfortunate crossing.
Thanks for fixing this.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2022-04-15 11:50:08 pgsql: Small cleanups in SQL/JSON code
Previous Message Andres Freund 2022-04-15 00:41:37 pgsql: pgstat: set timestamps of fixed-numbered stats after a crash.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-04-15 01:30:10 Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403)
Previous Message Peter Geoghegan 2022-04-15 01:18:40 Re: Intermittent buildfarm failures on wrasse