Re: typos

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Subject: Re: typos
Date: 2022-04-13 17:40:56
Message-ID: 20220413174056.GQ26620@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 13, 2022 at 07:29:34PM +0200, Alvaro Herrera wrote:
> On 2022-Apr-11, David Rowley wrote:
>
> > and also skipped:
> > 0016 (unsure if we should change these of pgindent is not touching it)
> > 0017 (unsure if we should change these of pgindent is not touching it)
>
> I verified that pgindent will indeed not touch these changes by running
> before and after. (I accepted one comment placement from that run that
> touched a neighboring line.)
>
> I think pgindent is right not to modify vertical space very much, since
> in many cases it amounts to a subjective decision. The patch seemed a
> (small) improvement, and it seems hard to make too much of a fuss about
> such things. Pushed them as a single commit.
>
> I hadn't noticed that Justin had posted a refreshed patch series, so I
> don't know if the new ones match what I pushed.

There were no changes - I had resent the patches that removed blank lines so it
was apparent that they were "outstanding" / under discussion.

There's (only) a few remaining.

Attachment Content-Type Size
0001-comment-spaces.patch text/x-diff 1.9 KB
0002-doc-review-locales.patch text/x-diff 3.8 KB
0003-doc-review-row-filters-for-logical-replication.patch text/x-diff 1.1 KB

In response to

  • Re: typos at 2022-04-13 17:29:34 from Alvaro Herrera

Responses

  • Re: typos at 2022-04-13 21:39:42 from David Rowley

Browse pgsql-hackers by date

  From Date Subject
Next Message Yedil Serzhan 2022-04-13 17:42:38 GSoC: <Develop Performance Farm Benchmarks and Website>
Previous Message Alvaro Herrera 2022-04-13 17:29:34 Re: typos