Re: pgsql: pgstat: store statistics in shared memory.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pgstat: store statistics in shared memory.
Date: 2022-04-07 07:31:49
Message-ID: 20220407073149.qsxf74oept7o435x@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2022-04-06 23:35:27 -0700, Andres Freund wrote:
> On 2022-04-07 15:09:27 +0900, Michael Paquier wrote:
> > On Thu, Apr 07, 2022 at 04:37:02AM +0000, Andres Freund wrote:
> > > pgstat: store statistics in shared memory.
> > >
> > > Previously the statistics collector received statistics updates via UDP and
> > > shared statistics data by writing them out to temporary files regularly. These
> > > files can reach tens of megabytes and are written out up to twice a
> > > second. This has repeatedly prevented us from adding additional useful
> > > statistics.
> >
> > rorqual, that uses --disable-spinlocks and --disable-atomics, is
> > unhappy after this commit:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-04-07%2005%3A47%3A03
> >
> > test_decoding is the one complaining here, and I can reproduce the
> > issue locally once I build the code with those switches.
>
> Yea, saw that too. About to push the fix...

And rorqual seems happy again.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2022-04-07 07:41:44 pgsql: Fix warning introduced in 5c279a6d350.
Previous Message Andres Freund 2022-04-07 07:23:40 pgsql: pgstat: add tests for transaction behaviour, 2PC, function stats