Re: shared-memory based stats collector - v70

At Wed, 6 Apr 2022 18:58:52 -0700, Andres Freund <andres(at)anarazel(dot)de> wrote in
> Hi,
>
> On 2022-04-07 10:36:30 +0900, Kyotaro Horiguchi wrote:
> > At Wed, 6 Apr 2022 09:04:09 -0700, Andres Freund <andres(at)anarazel(dot)de> wrote in
> > > I think there's no switches left now, so it's not actually providing too much.
> >
> > (Ouch!)
>
> I think it's great that there's no switches left - means we're pretty close to
> pgstat being runtime extensible...

Yes. I agree.

> It's now pgstat_get_kind_from_str().

I'm fine with it.

> It was harder to see earlier (I certainly didn't really see it) - because
> there were so many "violations" - but most of pgstat is
> pgstat_<verb>_<subject>() or just <verb>_<subject>. I'd already moved most of
> the patch series over to that (maybe in v68 or so). Now I also did that with
> the internal functions.
>
> There's a few functions breaking that pattern, partially because I added them
> :(, but since they're not touched in these patches I've not renamed them. But
> it's probably worth doing so tomorrow.

Thab being said, it gets far cleaner. Thanks!

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center