Re: [RFC] building postgres with meson -v8

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RFC] building postgres with meson -v8
Date: 2022-03-28 19:59:13
Message-ID: 20220328195913.rz3bllzhr26innoi@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-03-25 10:01:09 +0100, Peter Eisentraut wrote:
> On 22.03.22 03:22, Andres Freund wrote:
> > Attached is v8. It's just a rebase to resolve conflicts with recent changes.
>
> I have committed the DLSUFFIX refactoring, and also a stripped-down version
> of the patch that makes update-unicode work with vpath. This takes care of
> patches 0007 and 0009.

Thanks!

> The only other thing IMO that might be worth addressing in PG15 is the
> snowball scripts refactoring (0002 and 0003), but that doesn't seem quite
> ready yet. (At least, it would need to be integrated into the distprep
> target, since it adds a dependency on perl.) Maybe it's not worth it right
> now.

Not sure myself.

> With that, I suggest moving this patch set to CF 2022-07.

Done.

One thing I'd like to discuss fairly soon is what kind of approach to take for
integrating meson support. Most other projects I looked kept parallel
buildsystems for at least a release, so that there's one round of "broad" user
feedback.

In our context it could make sense to merge meson, after a few months of
shakeup remove the current windows buildsystems, and then in release + 1
remove the make based stuff.

But we can have that discussion that before the next CF, but still after
code-freeze & immediate mopup.

> A general comment on the remaining prereq patches: We appear to be
> accumulating a mix of conventions for how "generate" scripts specify their
> output file. Some have it built-in, some use the last argument, some use an
> option, which might be -o or --output. Maybe we can gently work toward more
> commonality there.

Fair point.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2022-03-28 20:03:33 Re: [PATCH v2] use has_privs_for_role for predefined roles
Previous Message Robert Haas 2022-03-28 19:56:18 Re: [PATCH v2] use has_privs_for_role for predefined roles