Re: pgsql: Enforce foreign key correctly during cross-partition updates

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Enforce foreign key correctly during cross-partition updates
Date: 2022-03-20 21:26:33
Message-ID: 202203202126.5susqfvj43q5@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2022-Mar-20, Tom Lane wrote:

> ==2663594== Conditional jump or move depends on uninitialised value(s)
> ==2663594== at 0x421526: ExecUpdateAct (nodeModifyTable.c:1855)

> It reproduces easily for me under valgrind. I guess
> ExecCrossPartitionUpdate must be failing to set
> inserted_tuple or insert_destrel.

Yeah, I was trying to reproduce it -- but it doesn't for me. Strange.
Anyway, I think you're right: insert_destrel is used in the test when
ExecCrossPartitionUpdate returns true, and clearly it can do that and
not set insert_destrel.

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"La grandeza es una experiencia transitoria. Nunca es consistente.
Depende en gran parte de la imaginación humana creadora de mitos"
(Irulan)

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-03-21 02:13:19 pgsql: pgstat: rename pgstat_initstats() to pgstat_relation_init().
Previous Message Alvaro Herrera 2022-03-20 21:25:15 pgsql: Blind fix for uninitialized memory bug in ba9a7e392171