| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add option to use ICU as global locale provider |
| Date: | 2022-03-20 11:46:26 |
| Message-ID: | 20220320114626.jqqbgg4isfyyefif@jrouhaud |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Mar 20, 2022 at 11:03:38AM +0100, Peter Eisentraut wrote:
> On 19.03.22 05:14, Julien Rouhaud wrote:
> > On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote:
> > > Hi,
> > >
> > > On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote:
> > > > Why does your patch introduce a function check_icu_locale() that is only
> > > > called once? Did you have further plans for that?
> > >
> > > I like that it moves ICU code out of dbcommands.c
> >
> > Yes, it seemed cleaner this way. But more importantly code outside pg_locale.c
> > really shouldn't have to deal with ICU specific version code.
> >
> > I'm attaching a v2, addressing Peter and Tom comments to not duplicate the old
> > ICU versions attribute function. I removed the ICU locale check entirely (for
> > consistency across ICU version) thus removing any need for ucol.h include in
> > initdb.
>
> committed
Thanks!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-03-20 16:31:34 | Re: pgsql: Add option to use ICU as global locale provider |
| Previous Message | Peter Eisentraut | 2022-03-20 10:04:17 | Re: pgsql: Add option to use ICU as global locale provider |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2022-03-20 12:58:01 | Re: Probable CF bot degradation |
| Previous Message | Tomas Vondra | 2022-03-20 11:23:39 | Re: Column Filtering in Logical Replication |