| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
| Date: | 2022-03-17 20:45:05 |
| Message-ID: | 20220317204505.GB1370751@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 17, 2022 at 06:48:43PM +0530, Bharath Rupireddy wrote:
> Personally, I tend to agree with v4-0001 (option (4)) or v4-0002
> (option (3)) than v4-0003 (option (1)) as it adds more unreadability
> with most of the code duplicated creating more diff with previous
> versions and maintainability problems. Having said that, I will leave
> it to the committer to decide on that.
I don't think v4-0003/option 1 needs to be unreadable. Perhaps we can use
a StringInfo to build the message. That might be a net improvement in
readability anyway.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-03-17 20:59:31 | Re: WIP: WAL prefetch (another approach) |
| Previous Message | Pavel Stehule | 2022-03-17 20:33:41 | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |