| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add index scan progress to pg_stat_progress_vacuum |
| Date: | 2022-03-12 21:20:04 |
| Message-ID: | 20220312212004.GA848429@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 12, 2022 at 07:00:06AM +0000, Imseih (AWS), Sami wrote:
>> nitpick: Can we remove the extra spaces in the parentheses?
>
> fixed
>
>> What does it mean if there isn't an entry in the map? Is this actually
>> expected, or should we ERROR instead?
>
> I cleaned up the code here and added comments.
>
>> I think the number of entries should be shared between
>> VacuumWorkerProgressShmemInit() and VacuumWorkerProgressShmemSize().
>> Otherwise, we might update one and not the other.
>
> Fixed
>
>> I think we should elaborate a bit more in this comment. It's difficult to
>> follow what this is doing without referencing the comment above
>> set_vacuum_worker_progress().
>
> More comments added
>
> I also simplified the 0002 patch as well.
These patches look pretty good to me. Barring additional feedback, I
intend to mark this as ready-for-committer early next week.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-03-12 22:13:47 | Re: Optimize external TOAST storage |
| Previous Message | Andres Freund | 2022-03-12 20:15:17 | Re: Issue with pg_stat_subscription_stats |