| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Chapman Flack <chap(at)anastigmatix(dot)net> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |
| Date: | 2022-03-11 00:38:34 |
| Message-ID: | 20220311003834.GA597706@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 10, 2022 at 07:13:14PM -0500, Chapman Flack wrote:
> Looks like this change to an example in func.sgml is not quite right:
>
> -postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
> +postgres=# SELECT * FROM pg_walfile_name_offset(pg_backup_stop());
>
> pg_backup_stop returns a record now, not just lsn. So this works for me:
>
> +postgres=# SELECT * FROM pg_walfile_name_offset((pg_backup_stop()).lsn);
Ah, good catch. I made this change in v7. I considered doing something
like this
SELECT w.* FROM pg_backup_stop() b, pg_walfile_name_offset(b.lsn) w;
but I think your suggestion is simpler.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-remove-exclusive-backup-mode.patch | text/x-diff | 86.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-03-11 01:02:23 | Re: refactoring basebackup.c |
| Previous Message | Chapman Flack | 2022-03-11 00:13:14 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |