| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Adding CI to our tree |
| Date: | 2022-03-10 21:00:10 |
| Message-ID: | 20220310210010.GG28503@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 10, 2022 at 12:50:15PM -0800, Andres Freund wrote:
> > - setup_cores_script: |
> > + setup_os_script: |
> > mkdir -m 770 /tmp/cores
> > chown root:postgres /tmp/cores
> > sysctl kern.corefile='/tmp/cores/%N.%P.core'
> > + #pkg install -y ...
>
> Would you mind if I split this into setup_core_files_script and
> setup_additional_packages_script:?
That's fine. FYI I'm also planning on using choco install --no-progress
I could resend my latest patches shortly.
> > Subject: [PATCH 6/7] wip: cirrus/windows: add compiler_warnings_script
> >
> > I'm not sure how to write this test in windows shell; it's also not easy to
> > write it in posix sh, since windows shell is somehow interpretting && and ||...
>
> That comment isn't accurate anymore now that it's in an external script,
> right?
No, it is accurate. What I mean is that it's also hard to write it as a
1-liner using posix sh, since the || (and &&) seemed to be interpretted by
cmd.exe and needed escaping - gross.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-03-10 21:00:41 | Re: role self-revocation |
| Previous Message | Stephen Frost | 2022-03-10 20:54:24 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |