| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Time to drop plpython2? |
| Date: | 2022-03-08 18:42:31 |
| Message-ID: | 20220308184231.umtrf44yyiz4wkok@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-03-07 20:59:16 -0800, Andres Freund wrote:
> On 2022-03-07 23:39:39 -0500, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > wrasse says you were too quick to drop plpython_error_5.out.
>
> Does look like it. I'll try to find a distribution with an old python...
debian 8 did the trick.
The output from older python was in plpython_error.out the output from newer
python in plpython_error_5.out. Looked like python2 specific output.
Pushed.
I guess I should have grokked the _5 suffix - but the _3 suffix was used for
python3 specific content, so it wasn't obvious. Should we rename the file to
plpython_error_35.out?
A bit depressing to have a 500 line alternative output file for a one line
diff :(.
> > Otherwise looks pretty good so far.
>
> crake also failed. Looks like plpy_plpymodule.h needs to include plpython.h. A
> pre-existing issue that just didn't happen to cause problems...
Fixed that.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-08 18:46:36 | Re: cpluspluscheck complains about use of register |
| Previous Message | Gunnar "Nick" Bluth | 2022-03-08 18:32:03 | Re: [PATCH] pg_stat_toast v8 |