| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | sk(at)zsrv(dot)org, pgsql-hackers(at)postgresql(dot)org, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: definition of CalculateMaxmumSafeLSN |
| Date: | 2022-03-01 04:44:40 |
| Message-ID: | 20220301044440.xh36kcm544vhy3dh@jrouhaud |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Mar 01, 2022 at 10:11:03AM +0900, Kyotaro Horiguchi wrote:
> At Mon, 28 Feb 2022 17:01:10 +0300, Sergei Kornilov <sk(at)zsrv(dot)org> wrote in
> > Hello
> > I just spotted in src/include/access/xlog.h:
> > extern XLogRecPtr CalculateMaxmumSafeLSN(void);
> >
> > This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
> > Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"
>
> Hmm. I think I remember of that name. You're right, it is a function
> that was once added during development of the commit but eventually
> gone.
>
> So it should be removed.
+1. I'm Ccing Álvaro as he's the committer.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2022-03-01 04:50:45 | Re: Schema variables - new implementation for Postgres 15 |
| Previous Message | Paul Jungwirth | 2022-03-01 04:31:55 | Re: range_agg with multirange inputs |