Re: pgsql: Move scanint8() to numutils.c

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Move scanint8() to numutils.c
Date: 2022-02-16 15:42:46
Message-ID: 20220216154246.s2zbaakmzmurozvs@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On Wed, Feb 16, 2022 at 08:24:31AM -0500, Robert Haas wrote:
> On Wed, Feb 16, 2022 at 6:09 AM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> > I don't think we have ever systematically release-noted backend API
> > changes. I don't know whether that would be useful, but a complete
> > treatment would be a significant effort (speaking from experience of
> > porting the mentioned pglogical between major releases).
>
> Personally, I don't think I would ever have used such a thing if it
> had existed, because looking through the git history seems more
> efficient to me. The release notes can be wrong or can fail to contain
> enough information to fix whatever issue I've encountered, but the
> offending commit always tells the real story. It sounds like Joe may
> feel differently which is fair enough; I can only speak to my own
> experience.

Agreed. I have been maintaining extensions for quite some time and the commit
log (and possibly the referenced discussions) always contains everything needed
to fix whatever code is broken with all the important details. I also try to
rebuild my extensions regularly against the current HEAD, so at the time the
release notes are written they wouldn't be of any use anyway.

The only reason I see to have something in the release notes would be to warn
about a problematic API change, which doesn't result in hard compilation
failure or something mostly immediate like that.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-02-16 16:06:12 Re: pgsql: Remove IS_AF_UNIX macro
Previous Message Robert Haas 2022-02-16 13:24:31 Re: pgsql: Move scanint8() to numutils.c

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-02-16 15:51:36 Re: refactoring basebackup.c (zstd)
Previous Message Robert Haas 2022-02-16 15:40:01 Re: adding 'zstd' as a compression algorithm