| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding |
| Date: | 2022-02-14 13:36:34 |
| Message-ID: | 202202141336.xv35beswc6ec@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2022-Feb-13, Tomas Vondra wrote:
> >> Fixing the tests however uncovered a bug in the code, because sequence
> >> callbacks did not handle skip-empty-xacts properly. For trasactional
> >> increments we need to check/update the xact_wrote_changes flag, and emit
> >> the BEGIN if it's the first change in the transaction.
> >
> > Hmm. Perhaps there should be a separate test script that runs various
> > things under skip-empty-xacts=0 and somehow protected against ancillary
> > activities (maybe a TAP test using autovacuum=0), just so that this new
> > code is covered ...
>
> I'm not sure what exactly would be the benefit?
Yeah, it's pointless.
I propose the attached comment additions instead.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| comments.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-02-14 14:05:02 | Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding |
| Previous Message | Heikki Linnakangas | 2022-02-14 09:34:10 | pgsql: Add test case for an archive recovery corner case. |