| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Date: | 2022-02-13 04:12:42 |
| Message-ID: | 20220213041242.xhpixy3kwwmswkfk@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-01-18 11:20:16 +0900, Michael Paquier wrote:
> On Sat, Jan 15, 2022 at 01:52:39PM +0800, Julien Rouhaud wrote:
> > libpq environment variable PGHOST has a non-local server value: C:/Users/ContainerAdministrator/AppData/Local/Temp/FhBIlsw6SV
> > Failure, exiting
> > not ok 3 - run of pg_upgrade for new instance
>
> There are two things here, as far as I understand:
> 1) This is a valid Windows path. So shouldn't we fix pg_upgrade's
> server.c to be a bit more compliant with Windows paths? The code
> accepts only paths beginning with '/' as local paths, so this breaks.
It also doesn't handle @ correctly. Makes sense to fix. Should probably use
the same logic that libpq, psql, ... use?
if (is_unixsock_path(ch->host))
ch->type = CHT_UNIX_SOCKET;
that'd basically be the same amount of code. And easier to understand.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-02-13 04:12:50 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Previous Message | Andres Freund | 2022-02-13 03:59:56 | Re: Mark all GUC variable as PGDLLIMPORT |