buildfarm warnings

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Subject: buildfarm warnings
Date: 2022-02-12 21:13:16
Message-ID: 20220212211316.GK31460@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Is there any check for warnings from new code, other than those buildfarm
members with -Werror ?

It'd be better to avoid warnings, allowing members to use -Werror, rather than
to allow/ignore warnings, which preclude that possibility. A circular problem.

I checked for warnings on master during "check" phase by opening many browser
tabs...

I'm of the impression that some people have sql access to BF logs. It seems
like it'd be easy to make a list of known/old/false-positive warnings and
ignore warnings matching (member,file,regex) to detect new warnings.

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=caiman&dt=2022-02-12%2006%3A00%3A30&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=moonjelly&dt=2022-02-12%2001%3A06%3A22&stg=make
rawhide prerelease / gcc trunk
pg_basebackup.c:1261:35: warning: storing the address of local variable archive_filename in progress_filename [-Wdangling-pointer=]
=> new in 23a1c6578 - looks like a real error

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=wrasse&dt=2022-02-12%2005%3A08%3A48&stg=make
Oracle Developer Studio
"/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/libpq/auth.c", line 104: warning: initialization type mismatch
"/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/commands/copy.c", line 206: warning: true part of ?: is unused and is nonconstant
"/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/utils/fmgr/fmgr.c", line 400: warning: assignment type mismatch:
"/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/access/common/reloptions.c", line 742: warning: argument #2 is incompatible with prototype:
=> "Size relopt_struct_size" looks wrong since 911e7020 (v13)

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=haddock&dt=2022-02-12%2000%3A23%3A17&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hake&dt=2022-02-12%2003%3A00%3A35&stg=make
llumos "rolling release"
pg_dump_sort.c:1232:3: warning: format not a string literal and no format arguments [-Wformat-security]

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=prairiedog&dt=2022-02-12%2009%3A52%3A07&stg=make
OSX/PPC
A lot of these, but some from new code (babbbb59)
pg_receivewal.c:288: warning: 'wal_compression_method' may be used uninitialized in this function
pg_receivewal.c:289: warning: 'ispartial' may be used uninitialized in this function

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gharial&dt=2022-02-12%2012%3A36%3A42&stg=make
HPUX
compress_io.c:532:4: warning: implicit declaration of function gzopen64 [-Wimplicit-function-declaration]
pg_backup_archiver.c:1521:4: warning: implicit declaration of function gzopen64 [-Wimplicit-function-declaration]
pg_backup_archiver.c:1521:11: warning: assignment makes pointer from integer without a cast [enabled by default]

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=anole&dt=2022-02-12%2005%3A46%3A44&stg=make
HPUX
"heapam_handler.c", line 2434: warning #2940-D: missing return statement at end of non-void function "heapam_scan_sample_next_tuple"
"regc_lex.c", line 762: warning #2940-D: missing return statement at end of non-void function "lexescape"
"fmgr.c", line 400: warning #2513-D: a value of type "void *" cannot be assigned to an entity of type "PGFunction"
"bbstreamer_gzip.c", line 92: warning #2223-D: function "gzopen64" declared implicitly

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=tern&dt=2022-02-12%2006%3A48%3A14&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=sungazer&dt=2022-02-12%2009%3A26%3A58&stg=make
ppc
auth.c:1876:6: warning: implicit declaration of function 'getpeereid'; did you mean 'getpgid'? [-Wimplicit-function-declaration]
missing #include ?

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=pollock&dt=2022-02-12%2004%3A35%3A53&stg=make
GCC10/illumos
pg_shmem.c:326:33: warning: passing argument 1 of 'shmdt' from incompatible pointer type [-Wincompatible-pointer-types]

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=pogona&dt=2022-02-12%2004%3A10%3A03&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=desmoxytes&dt=2022-02-12%2018%3A24%3A03&stg=make
LLVM: warning: void* memcpy(void*, const void*, size_t) writing to an object of type struct std::pair<void*, long unsigned int> with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=rorqual&dt=2022-02-12%2018%3A23%3A39&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=serinus&dt=2022-02-12%2005%3A00%3A08&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=calliphoridae&dt=2022-02-12%2004%3A07%3A11&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=culicidae&dt=2022-02-12%2004%3A07%3A13&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=piculet&dt=2022-02-12%2004%3A07%3A25&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=francolin&dt=2022-02-12%2004%3A07%3A44&stg=make
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=lorikeet&dt=2022-02-12%2002%3A11%3A43&stg=make
debian sid/gcc snapshot
numerous: variable ... might be clobbered by longjmp or vfork [-Wclobbered]

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=jacana&dt=2022-02-12%2007%3A36%3A32&stg=make
a huge number of these: this statement may fall through [-Wimplicit-fallthrough=]

--
Justin

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-02-12 21:23:10 Re: refactoring basebackup.c
Previous Message Justin Pryzby 2022-02-12 21:12:21 Re: refactoring basebackup.c