Re: Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules

From: Andres Freund <andres(at)anarazel(dot)de>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Move replication slot structures/enums/macros to a new header file for better usability by external tools/modules
Date: 2022-02-10 05:17:33
Message-ID: 20220210051733.tjygfn6cepqx7rth@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-02-07 10:52:08 +0530, Bharath Rupireddy wrote:
> While working on pg_replslotdata tool [1], it was observed that some
> of the replication slot structures/enums/macros such as
> ReplicationSlotPersistentData, ReplicationSlotPersistency,
> ReplicationSlotOnDisk, ReplicationSlotOnDiskXXXX etc. are currently in
> replication/slot.h and replication/slot.c. This makes the replication
> slot on disk data structures unusable by the external tools/modules.

FWIW, I still don't see a point in pg_replslotdata. And I don't think these
datastructures should ever be accessed outside the server environment.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-02-10 06:17:36 Re: Make mesage at end-of-recovery less scary.
Previous Message Bharath Rupireddy 2022-02-10 04:53:19 Use return value of XLogRecGetBlockTag instead of explicit block ref checks and also use XLogRecHasBlockRef/Image macros instead of explicit checks