Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-release(at)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Date: 2022-02-09 01:53:59
Message-ID: 20220209015359.wvstb5rxzj53zrtp@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2022-02-09 02:25:09 +0100, Tomas Vondra wrote:
> AFAICS this only affects builds with CLOBBER_CACHE_ALWAYS, and anyone
> running such build in production clearly likes painful things anyway.

Yea, realistically nobody does that.

> But really, for the infinite loop to happen, building a relation descriptor
> has to invalidate a cache. And I haven't found a way to do that without the
> CLOBBER_CACHE_ALWAYS thing.

Phew.

> Also, all the November minor releases include this commit, and there were no
> reports about this (pretty obvious) issue. Buildfarm did not complain either
> (but an animal may be stuck for months and we would not know about it).

Ah, somehow I thought that wasn't yet in the last set of releases. Phew #2.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2022-02-09 02:04:03 Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Previous Message Andres Freund 2022-02-09 01:43:34 Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2022-02-09 02:01:57 Re: [PATCH] Add min() and max() aggregate functions for xid8
Previous Message Euler Taveira 2022-02-09 01:46:33 Re: [BUG]Update Toast data failure in logical replication