| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |
| Date: | 2022-02-04 00:03:40 |
| Message-ID: | 20220204000340.GA1164333@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 03, 2022 at 09:45:08AM +0530, Bharath Rupireddy wrote:
> On Thu, Feb 3, 2022 at 12:07 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> If there is a problem reading the directory, we will LOG and then exit the
>> loop. If we didn't scan through all the entries in the directory, there is
>> a chance that we didn't fsync() all the files that need it.
>
> Thanks. I get it. For syncing map files, we don't want to tolerate any
> errors, whereas removal of the old map files (lesser than cutoff LSN)
> can be tolerated in CheckPointLogicalRewriteHeap.
LGTM. Andres noted upthread [0] that the comment above sscanf() about
skipping editors' lock files might not be accurate. I don't think it's a
huge problem if sscanf() matches those files, but perhaps we can improve
the comment.
[0] https://postgr.es/m/20220120194618.hmfd4kxkng2cgryh%40alap3.anarazel.de
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-02-04 00:07:42 | Re: Fix BUG #17335: Duplicate result rows in Gather node |
| Previous Message | Andrew Dunstan | 2022-02-03 22:25:51 | Re: fairywren is generating bogus BASE_BACKUP commands |