Hi,
On 2022-02-03 06:22:58 +0000, Etsuro Fujita wrote:
> Further fix for EvalPlanQual with mix of local and foreign partitions.
My compiler (as well as cfbot) now complains that there is an unused variable,
when building without assertions:
/home/andres/src/postgresql/src/backend/executor/nodeForeignscan.c: In function ‘ForeignNext’:
/home/andres/src/postgresql/src/backend/executor/nodeForeignscan.c:47:21: warning: unused variable ‘estate’ [-Wunused-variable]
47 | EState *estate = node->ss.ps.state;
| ^~~~~~
Seems best to just use node->ss.ps.state instead of the local estate variable?
Rather than using the noisier PG_USED_FOR_ASSERTS_ONLY.
I'll make it so, unless you want to?
Greetings,
Andres Freund