Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: 2022-01-31 01:35:48
Message-ID: 20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2022-01-31 00:44:39 +0000, Andres Freund wrote:
> plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure.
>
> For older versions we need our own copy of perl's setlocale(), because it was
> not exposed (why we need the setlocale in the first place is explained in
> plperl_init_interp) . The copy stopped working in 5.28, as some of the used
> macros are not public anymore. But Perl_setlocale is available in 5.28, so
> use that.
>
> Author: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
> Reviewed-By: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
> Discussion: https://postgr.es/m/20200501134711.08750c5f@antares.wagner.home
> Backpatch: all versions
>
> Branch
> ------
> REL_14_STABLE

I see this broke on everywhere but master. Looking.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-01-31 01:51:30 Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Previous Message Andres Freund 2022-01-31 00:44:51 pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai