| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Daniel Westermann <dwe(at)dbi-services(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
| Subject: | Re: support for MERGE |
| Date: | 2022-01-21 15:37:53 |
| Message-ID: | 202201211537.veim2rt3asdb@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jan-21, Japin Li wrote:
> + /*
> + * NOT MATCHED actions can't see target relation, but they can see
> + * source relation.
> + */
> + Assert(mergeWhenClause->commandType == CMD_INSERT ||
> + mergeWhenClause->commandType == CMD_DELETE ||
> + mergeWhenClause->commandType == CMD_NOTHING);
> + setNamespaceVisibilityForRTE(pstate->p_namespace,
> + targetRelRTE, false, false);
> + setNamespaceVisibilityForRTE(pstate->p_namespace,
> + sourceRelRTE, true, true);
>
> Should we remove the CMD_DELETE from Assert(), since it will not happened
> according to MERGE syntax?
Absolutely --- silly copy&paste mistake. Pushed fix.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
"Ni aún el genio muy grande llegaría muy lejos
si tuviera que sacarlo todo de su propio interior" (Goethe)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josef Šimánek | 2022-01-21 15:38:09 | Re: New developer papercut - Makefile references INSTALL |
| Previous Message | Tom Lane | 2022-01-21 15:31:07 | Re: New developer papercut - Makefile references INSTALL |