Re: Null commitTS bug

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, kingsboa(at)amazon(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Null commitTS bug
Date: 2022-01-20 03:00:56
Message-ID: 20220120.120056.82643992708364090.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 18 Jan 2022 13:48:11 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Tue, 18 Jan 2022 10:43:55 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> > On Sun, Jan 16, 2022 at 11:01:25PM -0500, Tom Lane wrote:
> > > Isn't that a very bad way to write "i = j + 1"?
> > >
> > > I agree with Horiguchi-san that
> > > for (i = 0, headxid = xid;;)
> >
> > Okay. Horiguchi-san, would you like to write a patch?
>
> Yes, I will.

This is that. I think this is a separate issue from the actual
bug. This is applicable at least back to 9.6 and I think this should
be applied back to all supported versions to avoid future backptach
conflicts.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-01-20 03:01:29 Re: pg_upgrade should truncate/remove its logs before running
Previous Message Kyotaro Horiguchi 2022-01-20 03:00:29 Re: Add checkpoint and redo LSN to LogCheckpointEnd log message