Re: a misbehavior of partition row movement (?)

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Arne Roland <A(dot)Roland(at)index(dot)de>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: a misbehavior of partition row movement (?)
Date: 2022-01-17 21:22:19
Message-ID: 202201172122.2bikr3kpfm27@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> @@ -3398,7 +3432,7 @@ typedef SetConstraintStateData *SetConstraintState;
> */
> typedef uint32 TriggerFlags;
>
> -#define AFTER_TRIGGER_OFFSET 0x0FFFFFFF /* must be low-order bits */
> +#define AFTER_TRIGGER_OFFSET 0x07FFFFFF /* must be low-order bits */
> #define AFTER_TRIGGER_DONE 0x10000000
> #define AFTER_TRIGGER_IN_PROGRESS 0x20000000
> /* bits describing the size and tuple sources of this event */
> @@ -3406,7 +3440,8 @@ typedef uint32 TriggerFlags;
> #define AFTER_TRIGGER_FDW_FETCH 0x80000000
> #define AFTER_TRIGGER_1CTID 0x40000000
> #define AFTER_TRIGGER_2CTID 0xC0000000
> -#define AFTER_TRIGGER_TUP_BITS 0xC0000000
> +#define AFTER_TRIGGER_CP_UPDATE 0x08000000
> +#define AFTER_TRIGGER_TUP_BITS 0xC8000000

So this patch releases one bit from AFTER_TRIGGER_OFFSET and makes it
become AFTER_TRIGGER_CP_UPDATE. As far as I can tell there is no harm
in doing so.

--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-01-17 21:27:48 Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations
Previous Message Robert Haas 2022-01-17 21:20:11 Re: Add last commit LSN to pg_last_committed_xact()