Re: In-placre persistance change of a relation

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: andres(at)anarazel(dot)de
Cc: Jakub(dot)Wartak(at)tomtom(dot)com, tsunakawa(dot)takay(at)fujitsu(dot)com, osumi(dot)takamichi(at)fujitsu(dot)com, sfrost(at)snowman(dot)net, masao(dot)fujii(at)oss(dot)nttdata(dot)com, ashutosh(dot)bapat(dot)oss(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: In-placre persistance change of a relation
Date: 2022-01-07 08:29:55
Message-ID: 20220107.172955.1331034596416944608.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 06 Jan 2022 16:39:21 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> Fantastic! I'll give it a try. Thanks!

I did that and found that the test stumbled on newlines.
Tests succeeded for other than Windows.

Windows version fails for a real known issue.

[7916][postmaster] LOG: received immediate shutdown request
[7916][postmaster] LOG: database system is shut down
[6228][postmaster] LOG: starting PostgreSQL 15devel, compiled by Visual C++ build 1929, 64-bit
[6228][postmaster] LOG: listening on Unix socket "C:/Users/ContainerAdministrator/AppData/Local/Temp/NcMnt2KTsr/.s.PGSQL.58698"
[2948][startup] LOG: database system was interrupted; last known up at 2022-01-07 07:12:14 GMT
[2948][startup] LOG: database system was not properly shut down; automatic recovery in progress
[2948][startup] LOG: redo starts at 0/1484280
[2948][startup] LOG: invalid record length at 0/14A47B8: wanted 24, got 0
[2948][startup] FATAL: could not remove file "base/12759/16384.u": Permission denied
[6228][postmaster] LOG: startup process (PID 2948) exited with exit code 1

Mmm.. Someone is still grasping the file after restart?

Anyway, I post the fixed version. This still fails on Windows..

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v15-0001-In-place-table-persistence-change.patch text/x-patch 82.2 KB
v15-0002-New-command-ALTER-TABLE-ALL-IN-TABLESPACE-SET-LO.patch text/x-patch 11.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2022-01-07 09:00:30 Re: Index-only scan for btree_gist turns bpchar to char
Previous Message Kyotaro Horiguchi 2022-01-07 08:27:40 Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers