Re: [PATCH] pg_stat_toast v6

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Gunnar 'Nick' Bluth <gunnar(dot)bluth(at)pro-open(dot)de>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, kuroda(dot)hayato(at)fujitsu(dot)com
Subject: Re: [PATCH] pg_stat_toast v6
Date: 2022-01-03 19:56:09
Message-ID: 20220103195609.GL24477@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 03, 2022 at 08:40:50PM +0100, Gunnar "Nick" Bluth wrote:
> I wonder why "track_toast.sql" test fails on Windows (with "ERROR:
> compression method lz4 not supported"), but "compression.sql" doesn't.
> Any hints?

The windows CI doesn't have LZ4, so the SQL command fails, but there's an
"alternate" expected/compression_1.out so that's accepted. (The regression
tests exercise many commands which fail, as expected, like creating an index on
an index).

If you're going have an alternate file for the --without-lz4 case, then I think
you should put it into compression.sql. (But not if you needed an alternate
for something else, since we'd need 4 alternates, which is halfway to 8...).

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message SATYANARAYANA NARLAPURAM 2022-01-03 20:10:32 Re: pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory
Previous Message Chapman Flack 2022-01-03 19:54:18 Re: TYPCATEGORY_{NETWORK,USER} [was Dubious usage of TYPCATEGORY_STRING]