| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Column Filtering in Logical Replication |
| Date: | 2022-01-03 14:40:57 |
| Message-ID: | 20220103144056.GB24477@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 03, 2022 at 11:31:39AM -0300, Alvaro Herrera wrote:
> > Did the DatumGetBool issue expose a deficiency in testing ?
> > I think the !am_partition path was never being hit.
>
> Hmm, the TAP test creates a subscription that contains both types of
> tables. I tried adding an assert for each case, and they were both hit
> on running the test.
Yes, I know both paths are hit now that it uses GetBool.
What I'm wondering is why tests didn't fail when one path wasn't hit - when it
said am_partition=DatumGetChar(); if (!am_partition){}
I suppose it's because the am_partition=true case correctly handles
nonpartitions.
Maybe the !am_partition case should be removed, and add a comment that
pg_partition_tree(pg_partition_root(%u))) also handles non-partitions.
Or maybe that's inefficient...
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Benesch | 2022-01-03 14:53:52 | Re: Remove inconsistent quotes from date_part error |
| Previous Message | Joel Jacobson | 2022-01-03 14:39:36 | Re: Foreign key joins revisited |