| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade should truncate/remove its logs before running |
| Date: | 2021-12-21 03:39:26 |
| Message-ID: | 20211221033926.GX17618@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 20, 2021 at 08:21:51PM +0900, Michael Paquier wrote:
> On Fri, Dec 17, 2021 at 11:21:13AM -0600, Justin Pryzby wrote:
> + log_opts.basedir = "pg_upgrade_log.d";
> we could choose something simpler for the default, like
> "pg_upgrade_log". I don't have a good history in naming new things,
> though :)
I specifically called it .d to made it obvious that it's a dir - nearly
everything that ends in "log" is a file, so people are likely to run "rm" and
"less" on it - including myself.
> .gitignore should be updated, I guess?
Are you suggesting to remove these ?
-/pg_upgrade_internal.log
-/reindex_hash.sql
-/loadable_libraries.txt
> Besides, this patch has no documentation.
TBH I'm not even sure if the dir needs to be configurable ?
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_upgrade-write-log-files-and-dumps-in-subdir.patch | text/x-diff | 13.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-12-21 03:46:30 | Re: do only critical work during single-user vacuum? |
| Previous Message | Amit Kapila | 2021-12-21 03:05:27 | Re: parallel vacuum comments |