Re: pgsql: Check that we have a working tar before trying to use it

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: 2021-12-09 02:16:04
Message-ID: 20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2021-12-08 12:53:29 -0500, Andrew Dunstan wrote:
> It would have passed the test and failed the invocation as before. It
> turns out that the tar being used is from the (old) MsysGit
> installation. So I'm rearranging the path so it finds the system tar
> instead. That should take care of things. (testing first before I do
> anything else). On my initial test the system tar handled paths with
> drive specs just fine.

I just hit this issue. The tar included in a just-updated git-for-windows
fails with "tar: Cannot connect to c: resolve failed".

Git appears to install itself in front of c:\windows\system32 in PATH (which
contains the system tar). Which I think means that after edc2332550 this will
have to be manually addressed by most people running tests on windows
manually? That doesn't seem great :(

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-12-09 02:18:54 Re: pgsql: Check that we have a working tar before trying to use it
Previous Message Peter Geoghegan 2021-12-09 01:25:52 pgsql: Standardize cleanup lock terminology.