Re: GUC flags

On Thu, Dec 02, 2021 at 02:11:38PM +0900, Michael Paquier wrote:
> On Wed, Dec 01, 2021 at 09:34:39PM -0600, Justin Pryzby wrote:
> >> @@ -2762,7 +2763,8 @@ static struct config_int ConfigureNamesInt[] =
> >> {"pre_auth_delay", PGC_SIGHUP, DEVELOPER_OPTIONS,
> >> - gettext_noop("Waits N seconds on connection startup before authentication."),
> >> + gettext_noop("Sets the amount of time to wait on connection "
> >> + "startup before authentication."),
> >> gettext_noop("This allows attaching a debugger to the process."),
> >
> > I wonder if these should say "Sets the amount of time to wait [before]
> > authentication during connection startup"
>
> Hmm. I don't see much a difference between both of wordings in this
> context.

I find it easier to read "wait before authentication ..." than "wait ... before
authentication".

> > BTW the EXPLAIN flag for enable_incremental_sort could be backpatched to v13.
>
> This could cause small diffs in EXPLAIN outputs, which could be
> surprising. This is not worth taking any risks.

Only if one specifies explain(SETTINGS).
It's fine either way ;)

--
Justin