| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Some RELKIND macro refactoring |
| Date: | 2021-11-23 15:36:15 |
| Message-ID: | 202111231536.b56wwkvlg2m7@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Nov-23, Alvaro Herrera wrote:
> On 2021-Nov-22, Peter Eisentraut wrote:
>
> > Maybe
> >
> > else
> > {
> > Assert(RELKIND_HAS_STORAGE(rel->rd_rel->relkind);
> > RelationCreateStorage(rel->rd_node, relpersistence);
> > }
> >
> > create_storage is set earlier based on RELKIND_HAS_STORAGE(), so this would
> > be consistent.
>
> Hmm, right ... but I think we can make this a little simpler. How about
> the attached?
This doesn't actually work, so nevermind that.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2021-11-23 15:37:03 | Re: ResourceOwner refactoring |
| Previous Message | Drouvot, Bertrand | 2021-11-23 15:22:19 | Re: Patch to avoid orphaned dependencies |