| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Windows build warnings |
| Date: | 2021-11-22 14:21:15 |
| Message-ID: | 202111221421.d5ddwad6kdcb@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Nov-22, Daniel Gustafsson wrote:
> > On 22 Nov 2021, at 12:10, Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> > I've attached a patch to fix these warnings.
>
> LGTM.
.. but see
https://postgr.es/m/CAH2-WznwWU+9on9nZCnZtk7uA238MCTgPxYr1Ty7U_Msn5ZGwQ@mail.gmail.com
where this was already discussed. I think if we're going to workaround
PG_USED_FOR_ASSERTS_ONLY not actually working, we may as well get rid of
it entirely. My preference would be to fix it so that it works on more
platforms (at least Windows in addition to GCC).
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth.
That's because in Europe they call me by name, and in the US by value!"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marek Kulik | 2021-11-22 14:23:59 | Building postgresql armv7 on emulated x86_64 |
| Previous Message | Alvaro Herrera | 2021-11-22 14:17:35 | Re: rename SnapBuild* macros in slot.c |