Re: standby recovery fails (tablespace related) (tentative patch and discussion)

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: daniel(at)yesql(dot)se, guopa(at)vmware(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, ibrar(dot)ahmad(at)gmail(dot)com, alvherre(at)2ndquadrant(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, a(dot)lubennikova(at)postgrespro(dot)ru, pasim(at)vmware(dot)com, thomas(dot)munro(at)gmail(dot)com, horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Date: 2021-11-10 08:14:11
Message-ID: 20211110.171411.1604652159337106356.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 09 Nov 2021 17:05:49 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Tue, 9 Nov 2021 12:51:15 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> > Look at Utils.pm where we have dir_symlink, then. symlink() does not
> > work on WIN32, so we have a wrapper that uses junction points. FWIW,
> > I don't like much the behavior you are enforcing in init_from_backup
> > when coldly copying a source path, but I have not looked enough at the
> > patch set to have a strong opinion about this part, either.
>
> Thanks for the info. If we can handle symlink on Windows, we don't
> need to have a cold copy.

I bumped into the good-old 100-byte limit of the (v7?) tar format on
which pg_basebackup is depending. It is unlikely in the real world but
I think it is quite common in developping environment. The tablespace
directory path in my dev environment was 110 chacters-long. As small
as 10 bytes but it's quite annoying to chip off that number of bytes
from the path..

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rafia Sabih 2021-11-10 08:17:22 Re: Add connection active, idle time to pg_stat_activity
Previous Message Dilip Kumar 2021-11-10 08:05:31 Re: Add connection active, idle time to pg_stat_activity